TEST: Verify ARM canary catches crc-fast 1.4 SIGILL (do not merge)#4609
Draft
TEST: Verify ARM canary catches crc-fast 1.4 SIGILL (do not merge)#4609
Conversation
Expand the smithy-rs canary to deploy and run ARM64 (aarch64) Lambda functions in addition to x86_64, catching architecture-specific runtime bugs like the crc-fast 1.4 SIGILL incident before merge. Changes: - Add --architecture flag to canary runner (run.rs), wire through to Lambda creation with .architectures() and arch-aware runtime selection (provided.al2 for x86_64, provided.al2023 for aarch64) - Add architecture-suffixed Lambda function names to prevent collisions when both canaries run in parallel - Accept architecture as 5th arg in run-canary script - Skip cross-compilation tool when building natively on ARM - Reduce hash truncation in bundle names (24->16 chars) to leave headroom for architecture suffix within Lambda 64-char name limit - Add canary-arm CI job that runs directly on ubuntu-24.04-arm without Docker (the existing Docker build image is x86_64-only in ECR) - Existing x86_64 canary is unchanged Supersedes #4428. Addresses #4380.
The canary runner builds the Lambda binary with --target=aarch64-unknown-linux-musl, but the musl target needs to be explicitly added via rustup since it's not included by default in the stable toolchain.
|
A new generated diff is ready to view.
A new doc preview is ready to view. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE — Test PR only
This PR verifies that the ARM64 canary added in #4606 would have caught the
crc-fast 1.4 SIGILL bug that shipped to customers (see #4264, #4380).
What this does:
crc-fast = "=1.4.0"(the version with the AVX-512 SIGILL bug)Expected result:
Canary (aarch64)) should fail with a runtime errorAfter verification: This PR will be closed. The evidence will be linked in #4606.