Bump TypeScript to ~5.4.x in smithy JS packages#1263
Closed
Conversation
This was referenced May 8, 2024
Merged
Merged
trivikr
force-pushed
the
bump-typescript
branch
3 times, most recently
from
ed99d53 to
86516a0
Compare
Merged
This comment was marked as outdated.
This comment was marked as outdated.
Contributor
Author
|
The karma tests are failing even after bumping to 5.4.5 $ hash-blob-browser> yarn test
10 05 2024 15:28:15.612:INFO [compiler.karma-typescript]: Compiling project using Typescript 5.4.5
10 05 2024 15:28:18.963:INFO [compiler.karma-typescript]: Compiled 10 files in 3340 ms.
10 05 2024 15:28:19.874:INFO [karma-server]: Karma v6.4.3 server started at http://localhost:9876/
10 05 2024 15:28:19.874:INFO [launcher]: Launching browsers ChromeHeadlessNoSandbox with concurrency unlimited
10 05 2024 15:28:19.877:INFO [launcher]: Starting browser ChromeHeadless
10 05 2024 15:28:20.043:INFO [Chrome Headless 113.0.5672.126 (Linux x86_64)]: Connected on socket juFy_dpZniJlL0_bAAAB with id 94162323
Chrome Headless 113.0.5672.126 (Linux x86_64) ERROR
An error was thrown in afterAll
Uncaught ReferenceError: exports is not defined
ReferenceError: exports is not defined
at src/index.js:2:5879
Uncaught ReferenceError: exports is not defined
ReferenceError: exports is not defined
at src/index.spec.js:38:23
Chrome Headless 113.0.5672.126 (Linux x86_64): Executed 0 of 0 ERROR (0 secs / 0 secs)
Chrome Headless 113.0.5672.126 (Linux x86_64) ERROR
An error was thrown in afterAll
Uncaught ReferenceError: exports is not defined
ReferenceError: exports is not defined
at src/index.js:2:5879
Uncaught ReferenceError: exports is not defined
ReferenceError: exports is not defined
Chrome Headless 113.0.5672.126 (Linux x86_64): Executed 0 of 0 ERROR (0.009 secs / 0 secs)This is a simple test, and the fix does not look straightforward. If fixing the test is difficult, an alternative would be to switch karma tests to Web Test Runner, but disable running them in unsupported Node.js 16.x |
Contributor
Author
|
The karma tests don't fail in 5.2.2 10 05 2024 16:30:00.821:INFO [compiler.karma-typescript]: Compiling project using Typescript 5.2.2
10 05 2024 16:30:03.991:INFO [compiler.karma-typescript]: Compiled 10 files in 3160 ms.
10 05 2024 16:30:04.571:INFO [bundler.karma-typescript]: Bundled imports for 2 file(s) in 79 ms.
10 05 2024 16:30:04.971:INFO [karma-server]: Karma v6.4.3 server started at http://localhost:9876/
10 05 2024 16:30:04.971:INFO [launcher]: Launching browsers ChromeHeadlessNoSandbox with concurrency unlimited
10 05 2024 16:30:04.974:INFO [launcher]: Starting browser ChromeHeadless
10 05 2024 16:30:05.156:INFO [Chrome Headless 113.0.5672.126 (Linux x86_64)]: Connected on socket 7LLsvyY3-c3AqBhNAAAB with id 56571753
Chrome Headless 113.0.5672.126 (Linux x86_64): Executed 1 of 1 SUCCESS (0.013 secs / 0.005 secs)
TOTAL: 1 SUCCESSI'll post a separate PR for it |
This was referenced May 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
TypeScript releases:
Description of changes:
Bump TypeScript to ~5.4.x in smithy JS packages
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.