Skip to content

add semigroup to growing append#248

Open
Benjamin-McRae-Tracsis wants to merge 3 commits into
snoyberg:mono-traversable-1.1.0.0from
Benjamin-McRae-Tracsis:semigroup-growing-append
Open

add semigroup to growing append#248
Benjamin-McRae-Tracsis wants to merge 3 commits into
snoyberg:mono-traversable-1.1.0.0from
Benjamin-McRae-Tracsis:semigroup-growing-append

Conversation

@Benjamin-McRae-Tracsis

Copy link
Copy Markdown

closes #246

@BebeSparkelSparkel BebeSparkelSparkel changed the base branch from master to mono-traversable-1.1.0.0 November 20, 2024 15:28
@BebeSparkelSparkel

Copy link
Copy Markdown
Collaborator

I have created branch mono-traversable-1.1.0.0 to add the multiple breaking changes to before their addition to master.

@BebeSparkelSparkel BebeSparkelSparkel added the breaking breaking changes in PR label Nov 20, 2024
@Benjamin-McRae-Tracsis

Copy link
Copy Markdown
Author

Hi, what more do I need to do to begin the process of merging this and my other PR?

@BebeSparkelSparkel

Copy link
Copy Markdown
Collaborator

@Benjamin-McRae-Tracsis

  • Edit the comment to reflect the new constraint.
  • Add a since version to the class comment for the constraint
  • Add an entry to the changelog

@Benjamin-McRae-Tracsis

Copy link
Copy Markdown
Author

Sorry it took so long, been busy in other things; I no longer use this account too much, but would be nice to wrap things up.

@BebeSparkelSparkel

Copy link
Copy Markdown
Collaborator

@Benjamin-McRae-Tracsis I updated the mono-traversable-instances dependency version and it builds on my machine. For some reason the PR is not switching to the latest head, can you rebase onto the head of snoyberg:mono-traversable-1.1.0.0 and force push your pr Benjamin-McRae-Tracsis:mono-traversable?

@L0neGamer

Copy link
Copy Markdown
Contributor

Let me know if the above workflow works for you! (this is my main account)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking breaking changes in PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Semigroup on GrowingAppend

3 participants