Enabled native groupBy for vector#252
Open
BebeSparkelSparkel wants to merge 1 commit into
Open
Conversation
groupBy been available since vector-0.13.0.0 closes snoyberg#251
Collaborator
Author
|
@jcmartin Since you were sort of involved with this. Could you review this? |
Contributor
|
@BebeSparkelSparkel I added my small nitpicks. I think the bigger thing we should do is consider adding a 9.8.3 release from stackage to the continuous integration. This will require a |
Collaborator
Author
|
@jcmartin Sorry, I do not see your nitpicks. If you have any changes you want to make for the workflows, I'll review them in a PR. Thanks |
Contributor
|
The nitpick is that |
jcmartin
reviewed
Dec 4, 2024
| | otherwise = Just (U.init v, U.last v) | ||
| --groupBy = U.groupBy | ||
| #if MIN_VERSION_vector(0,13,0) | ||
| -- | since 1.0.21.1 |
Contributor
There was a problem hiding this comment.
I think you mean @since. There are a few instances of this.
| | otherwise = Just (V.init v, V.last v) | ||
| --groupBy = V.groupBy | ||
| #if MIN_VERSION_vector(0,13,0) | ||
| -- | since 1.0.21.1 |
| | otherwise = Just (VS.init v, VS.last v) | ||
| --groupBy = U.groupBy | ||
| #if MIN_VERSION_vector(0,13,0) | ||
| -- | since 1.0.21.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
groupBy been available since vector-0.13.0.0
closes #251