fix(ios): prevent VoiceOver crash on stale accessibility ranges#187
Merged
hryhoriiK97 merged 1 commit intomainfrom Mar 27, 2026
Merged
fix(ios): prevent VoiceOver crash on stale accessibility ranges#187hryhoriiK97 merged 1 commit intomainfrom
hryhoriiK97 merged 1 commit intomainfrom
Conversation
When rendered markdown content becomes shorter before accessibility elements are rebuilt, VoiceOver can request frame information using character ranges from the previous render. These stale ranges exceed the current text length and crash in NSLayoutManager glyphRangeForCharacterRange:. Fix: - Clear _accessibilityElements and set _accessibilityNeedsRebuild atomically before updating attributedText so VoiceOver never sees stale element references during the update window. - Clamp character ranges in frameForRange:inTextView:container: so out-of-bounds requests return CGRectZero instead of crashing. - Remove redundant _accessibilityNeedsRebuild assignments that could race with the atomic invalidation. Closes #183 Made-with: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When rendered markdown content becomes shorter before accessibility elements are rebuilt, VoiceOver can request frame information using character ranges from the previous render. These stale ranges exceed the current text length and crash in NSLayoutManager glyphRangeForCharacterRange:.
Closes #183
What/Why?
Testing
PR Checklist