fix(macos): use correct textContainerInset properties for caret rect#247
Merged
hryhoriiK97 merged 3 commits intomainfrom Apr 16, 2026
Merged
fix(macos): use correct textContainerInset properties for caret rect#247hryhoriiK97 merged 3 commits intomainfrom
hryhoriiK97 merged 3 commits intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Fixes caret positioning on macOS by using the correct NSEdgeInsets properties (.left/.top) instead of .width/.height when computing the caret rect offset from textContainerInset. The previous properties are incorrect for NSEdgeInsets and could result in a mispositioned cursor.
Testing
PR Checklist