fix(android): span with background should show up inside blockquotes#253
Merged
hryhoriiK97 merged 4 commits intosoftware-mansion-labs:mainfrom Apr 24, 2026
Conversation
Open
4 tasks
hryhoriiK97
requested changes
Apr 22, 2026
Collaborator
hryhoriiK97
left a comment
hryhoriiK97
left a comment
There was a problem hiding this comment.
@xindixu thank you for the PR! I've left a few comments 🙂
…pan flags - Add SPAN_FLAGS_CONTAINER_BACKGROUND (max priority) so blockquote draws before lower-priority LineBackgroundSpans on the same line. - Implement LineBackgroundSpan on BlockquoteSpan and move fill from drawLeadingMargin to drawBackground; keep accent bars in drawLeadingMargin. - Unblocks inline chip/pill backgrounds rendering above blockquote fill. Made-with: Cursor
xindixu
force-pushed
the
feat/android-blockquote-container-background
branch
from
5d7e99a to
1192f25
Compare
Contributor
Author
|
@hryhoriiK97 - Thank you for the review! I've addressed all your comments. Here's the updated screenshot after the fix. PTAL 😃 
|
hryhoriiK97
approved these changes
Apr 24, 2026
Collaborator
hryhoriiK97
left a comment
hryhoriiK97
left a comment
There was a problem hiding this comment.
LGTM 🚀 Thanks for the contribution, @xindixu! This will go out in tomorrow's nightly release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What/Why?
Text spans with background inside blockquotes don't have their background showing properly in Android.
Testing
Render code with background color inside blockquotes.
Screenshots
PR Checklist