Skip to content

fix(ios): spoiler not rendering after keystroke#280

Merged
hryhoriiK97 merged 1 commit intofeat/example-app-test-playgroundfrom
fix-ios/spoiler-not-rendering-after-keystroke
Apr 30, 2026
Merged

fix(ios): spoiler not rendering after keystroke#280
hryhoriiK97 merged 1 commit intofeat/example-app-test-playgroundfrom
fix-ios/spoiler-not-rendering-after-keystroke

Conversation

@eszlamczyk
Copy link
Copy Markdown
Collaborator

@eszlamczyk eszlamczyk commented Apr 29, 2026

What/Why?

While (check video section) working on playground I've found out that ||spoilers|| on IOS are not rendering properly when we try to render them after last | keystroke (so ||test| -> ||test||). This fixes the issue by setting needsLayout flag to trigger render of spoiler "frame" during re-render.

Testing

  • open playground on IOS
  • type ||test| into input field -> add missing | to create spoiler
    • expected: spoiler is being created
  • turn on || (spoiler) mode
    • expected: spoiler is being created in both input field and rendered field

Video

Before
Screen.Recording.2026-04-29.at.19.05.39.mov
After
Screen.Recording.2026-04-29.at.18.59.25.mov

PR Checklist

  • Code compiles and runs on iOS
  • Code compiles and runs on Android
  • Updated documentation/README if applicable
  • Ran example app to verify changes

@eszlamczyk eszlamczyk requested a review from hryhoriiK97 April 29, 2026 16:58
@eszlamczyk eszlamczyk marked this pull request as ready for review April 29, 2026 17:10
Copy link
Copy Markdown
Collaborator

@hryhoriiK97 hryhoriiK97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎖️

@hryhoriiK97 hryhoriiK97 merged commit fad2ad0 into feat/example-app-test-playground Apr 30, 2026
@eszlamczyk eszlamczyk deleted the fix-ios/spoiler-not-rendering-after-keystroke branch April 30, 2026 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants