Skip to content

fix(ios): break retain cycle between renderers and RendererFactory #284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hryhoriiK97 merged 1 commit into from
May 1, 2026
Merged

fix(ios): break retain cycle between renderers and RendererFactory #284

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ios/renderer/BlockquoteRenderer.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
static NSString *const kNestedInfoRangeKey = @"range";

@implementation BlockquoteRenderer {
RendererFactory *_rendererFactory;
__weak RendererFactory *_rendererFactory;
StyleConfig *_config;
}

Expand Down
2 changes: 1 addition & 1 deletion ios/renderer/CodeBlockRenderer.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#import "StyleConfig.h"

@implementation CodeBlockRenderer {
RendererFactory *_rendererFactory;
__weak RendererFactory *_rendererFactory;
StyleConfig *_config;
}

Expand Down
2 changes: 1 addition & 1 deletion ios/renderer/CodeRenderer.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
#import <React/RCTFont.h>

@implementation CodeRenderer {
RendererFactory *_rendererFactory;
__weak RendererFactory *_rendererFactory;
StyleConfig *_config;
}

Expand Down
2 changes: 1 addition & 1 deletion ios/renderer/ENRMImageRenderer.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
static const unichar kZeroWidthSpace = 0x200B;

@implementation ENRMImageRenderer {
RendererFactory *_rendererFactory;
__weak RendererFactory *_rendererFactory;
StyleConfig *_config;
}

Expand Down
2 changes: 1 addition & 1 deletion ios/renderer/ENRMMathInlineRenderer.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
#if ENRICHED_MARKDOWN_MATH

@implementation ENRMMathInlineRenderer {
RendererFactory *_rendererFactory;
__weak RendererFactory *_rendererFactory;
StyleConfig *_config;
}

Expand Down
2 changes: 1 addition & 1 deletion ios/renderer/ENRMSpoilerRenderer.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#import "RendererFactory.h"

@implementation ENRMSpoilerRenderer {
RendererFactory *_rendererFactory;
__weak RendererFactory *_rendererFactory;
}

- (instancetype)initWithRendererFactory:(id)rendererFactory config:(__unused id)config
Expand Down
2 changes: 1 addition & 1 deletion ios/renderer/EmphasisRenderer.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
#import <React/RCTFont.h>

@implementation EmphasisRenderer {
RendererFactory *_rendererFactory;
__weak RendererFactory *_rendererFactory;
StyleConfig *_config;
}

Expand Down
2 changes: 1 addition & 1 deletion ios/renderer/HeadingRenderer.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@
@"heading-4", @"heading-5", @"heading-6"};

@implementation HeadingRenderer {
RendererFactory *_rendererFactory;
__weak RendererFactory *_rendererFactory;
StyleConfig *_config;
}

Expand Down
2 changes: 1 addition & 1 deletion ios/renderer/LinkRenderer.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#import <React/RCTFont.h>

@implementation LinkRenderer {
RendererFactory *_rendererFactory;
__weak RendererFactory *_rendererFactory;
StyleConfig *_config;
}

Expand Down
2 changes: 1 addition & 1 deletion ios/renderer/ListItemRenderer.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ - (void)applyCheckedDecorationsTo:(NSMutableAttributedString *)output
@end

@implementation ListItemRenderer {
RendererFactory *_rendererFactory;
__weak RendererFactory *_rendererFactory;
StyleConfig *_config;
}

Expand Down
2 changes: 1 addition & 1 deletion ios/renderer/ListRenderer.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
#import "StyleConfig.h"

@implementation ListRenderer {
RendererFactory *_rendererFactory;
__weak RendererFactory *_rendererFactory;
StyleConfig *_config;
BOOL _isOrdered;
}
Expand Down
2 changes: 1 addition & 1 deletion ios/renderer/ParagraphRenderer.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
#import "StyleConfig.h"

@implementation ParagraphRenderer {
RendererFactory *_rendererFactory;
__weak RendererFactory *_rendererFactory;
StyleConfig *_config;
}

Expand Down
2 changes: 1 addition & 1 deletion ios/renderer/StrikethroughRenderer.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#import "StyleConfig.h"

@implementation StrikethroughRenderer {
RendererFactory *_rendererFactory;
__weak RendererFactory *_rendererFactory;
StyleConfig *_config;
}

Expand Down
2 changes: 1 addition & 1 deletion ios/renderer/StrongRenderer.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
#import <React/RCTFont.h>

@implementation StrongRenderer {
RendererFactory *_rendererFactory;
__weak RendererFactory *_rendererFactory;
StyleConfig *_config;
}

Expand Down
2 changes: 1 addition & 1 deletion ios/renderer/UnderlineRenderer.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#import "StyleConfig.h"

@implementation UnderlineRenderer {
RendererFactory *_rendererFactory;
__weak RendererFactory *_rendererFactory;
StyleConfig *_config;
}

Expand Down
Loading
⚡