Skip to content

Readme instructions for Expo broken #5

@shamilovtim

Description

@shamilovtim

Before submitting a new issue

  • I tested using the latest version of the library, as the bug might be already fixed.
  • I tested using a supported version of react native.
  • I checked for possible duplicate issues, with possible answers.

Bug summary

The expo specific instructions have several broken lines of code.

// defaultResolver is undefined
const defaultResolver = config.resolver.resolveRequest;

Now if you fix that:

const defaultResolver = config.resolver;


config = getBundleModeMetroConfig(config);

config.resolver.resolveRequest = (context, moduleName, platform) => {
  if (moduleName.startsWith("react-native-worklets/.worklets/")) {
    return bundleModeMetroConfig.resolver.resolveRequest(
      context,
      moduleName,
      platform,
    );
  }
  return defaultResolver.resolveRequest(context, moduleName, platform);
};

module.exports = config;

there's a new bug:

Metro has encountered an error: Maximum call stack size exceeded: 
metro.config.js (22:18)

  20 |
  21 | config.resolver.resolveRequest = (context, moduleName, platform) => {
> 22 |   if (moduleName.startsWith("react-native-worklets/.worklets/")) {
     |                  ^
  23 |     return bundleModeMetroConfig.resolver.resolveRequest(
  24 |       context,
  25 |       moduleName,

Library version

0.8.1

Environment info

react native: 0.83.4
expo: 55.0.8

Steps to reproduce

This is a docs init bug

Reproducible example repository

N/A

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions