test(Fabric): add e2e test for issue 577#2816
Merged
Conversation
Contributor
Author
|
After splitting tests into seperate files, CI fails on Android because some tests are iOS-only. We need to figure out how to handle it. |
Member
|
I don't know the details yet, but maybe lets add some |
0571990 to
43d5f55
Compare
Contributor
Author
|
We might consider using |
Contributor
Author
|
It turns out that |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Check which example screens from issues/PRs can be used in e2e testing for tests
Test550, ..., Test577and implement them if possible for Fabric.Test550
Skipped because the issue is present on the current version (custom native header back button image). When it is resolved, we might create an e2e test for it.
Test556
Skipped because we can't check flickering nor non-deterministic white screen bug.
Test564
Skipped because the issue is still present on the current version (headers overlapping when one navigatior has
headerTransparent: true). When it is resolved, we might create an e2e test for it.Test577
Test created. It checks whether attempting to close a
gestureEnabled: falsemodal on iOS doesn't break the modal's height allowing the content underneath to be visible. The test is present only on iOS because of differences inmodalbetween iOS and Android.Changes
Test577apps/src/tests/index.tswith the reason for (not) implementing e2e test for ite2e-utils.tswithdecribeIfiOSfunction that will skip running the tests if they are run on AndroidTest code and steps to reproduce
CI
Checklist