-
-
Notifications
You must be signed in to change notification settings - Fork 643
fix(iOS): useHeaderHeight does not report correct value after cancelling search
#2817
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
6cce021
fix: fix header height
maciekstosio b6fbfea
chore: add test case
maciekstosio 3c156b8
Merge branch 'main' into @maciekstosio/Fix-useHeaderHeight
maciekstosio 97e4b0d
chore: add changes from comments
maciekstosio f27cc42
Update ios/RNSScreenStack.mm
maciekstosio File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,36 @@ | ||
| import { ScrollView, Text } from 'react-native'; | ||
| import { NavigationContainer } from '@react-navigation/native'; | ||
| import { createNativeStackNavigator } from '@react-navigation/native-stack'; | ||
| import { useHeaderHeight } from '@react-navigation/elements'; | ||
|
|
||
| const Stack = createNativeStackNavigator(); | ||
|
|
||
| function HomeScreen() { | ||
| const margin = useHeaderHeight(); | ||
|
|
||
| return ( | ||
| <ScrollView style={{ | ||
| marginTop: margin, | ||
| }}> | ||
| <Text style={{textAlign: "center"}}>focus and then cancel to see if position updates</Text> | ||
| </ScrollView> | ||
| ); | ||
| } | ||
|
|
||
| function RootStack() { | ||
| return ( | ||
| <Stack.Navigator> | ||
| <Stack.Screen name="InitialScreen" component={HomeScreen} options={{ | ||
| headerSearchBarOptions: {}, | ||
| }} /> | ||
| </Stack.Navigator> | ||
| ); | ||
| } | ||
|
|
||
| export default function App() { | ||
| return ( | ||
| <NavigationContainer> | ||
| <RootStack /> | ||
| </NavigationContainer> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The condition is ok, but naming is misleading.
Either rename the variable to
isNotDismissingModalOrPresentingSearchControllerorsplit this condition - leave
isNotDismissingModalas is and add new variableisNotPresentingSearchControllerand use it below.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, I think the naming is correct, although it's unnecessarily (?) complicated.
and then
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changed in: 97e4b0d