fix(Windows): fix building and crashing issues#2826
Merged
Conversation
kkafar
reviewed
Apr 4, 2025
Member
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
Please also check which source files are required by metor by default (e.g. Screen.tsx or Screen.web.tsx)
kkafar
requested changes
Apr 4, 2025
Member
kkafar
left a comment
kkafar
left a comment
There was a problem hiding this comment.
Okay, so we need to get rid of unused code / code introduced only to simplify debug.
We need to check whether search bar has any functionality here.
Andddd, we'll what do we do later.
Contributor
Author
Windows apps use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes problems with building and crashes in Windows apps. Some components are still WIP and we'll finish work on them in the future.
Resolves #2541.
Changes
ScreenContentWrapperandScreenFooter,WindowsTargetPlatformto matchWinUIrequirements,Test code and steps to reproduce
Create new
react-native-windowsapp with components fromreact-native-screens, build and run (it might be necessary to runnpx react-native run-windowstwice in order to install all required packages).