chore(Android): remove legacy architecture related code#3836
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes all Paper/old architecture-related code from the Android configuration and implementation, completing the migration to the new React Native architecture. The project now assumes all builds use the new architecture exclusively.
Changes:
- Remove
@ReactPropannotations and import from SearchBarManager that were part of the legacy prop system - Remove all conditional new architecture guards from CMakeLists.txt, keeping only the new architecture code path
- Remove new architecture feature flag and related configuration from build.gradle, simplifying plugin application logic
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| android/src/main/java/com/swmansion/rnscreens/SearchBarManager.kt | Removed @ReactProp annotations and import; methods remain as interface implementations handled by the delegate pattern |
| android/CMakeLists.txt | Removed all conditional compilation guards; consolidated to new architecture code path with fbjni dependency |
| android/build.gradle | Removed isNewArchitectureEnabled() function and feature flag; React Gradle plugin now conditionally applied based on repo context rather than architecture flag |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
t0maboro
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes all Paper-related code leftovers on Android.
Closes https://github.com/software-mansion/react-native-screens-labs/issues/1033
Changes
ReactPropannotations fromSearchBarManager.ktbuild.gradleandCMakeLists.txtBefore & after - visual documentation
N/A
Test plan
Build app.
Checklist