Skip to content

chore(Android): remove legacy architecture related code#3836

Merged
sgaczol merged 2 commits intomainfrom
@sgaczol/android-paper-removal-misc
Apr 2, 2026
Merged

chore(Android): remove legacy architecture related code#3836
sgaczol merged 2 commits intomainfrom
@sgaczol/android-paper-removal-misc

Conversation

@sgaczol
Copy link
Copy Markdown
Collaborator

@sgaczol sgaczol commented Apr 2, 2026

Description

This PR removes all Paper-related code leftovers on Android.

Closes https://github.com/software-mansion/react-native-screens-labs/issues/1033

Changes

  • remove ReactProp annotations from SearchBarManager.kt
  • remove new architecture guards from build.gradle and CMakeLists.txt

Before & after - visual documentation

N/A

Test plan

Build app.

Checklist

  • Ensured that CI passes

@sgaczol sgaczol marked this pull request as ready for review April 2, 2026 10:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes all Paper/old architecture-related code from the Android configuration and implementation, completing the migration to the new React Native architecture. The project now assumes all builds use the new architecture exclusively.

Changes:

  • Remove @ReactProp annotations and import from SearchBarManager that were part of the legacy prop system
  • Remove all conditional new architecture guards from CMakeLists.txt, keeping only the new architecture code path
  • Remove new architecture feature flag and related configuration from build.gradle, simplifying plugin application logic

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
android/src/main/java/com/swmansion/rnscreens/SearchBarManager.kt Removed @ReactProp annotations and import; methods remain as interface implementations handled by the delegate pattern
android/CMakeLists.txt Removed all conditional compilation guards; consolidated to new architecture code path with fbjni dependency
android/build.gradle Removed isNewArchitectureEnabled() function and feature flag; React Gradle plugin now conditionally applied based on repo context rather than architecture flag

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sgaczol sgaczol merged commit 99e53d8 into main Apr 2, 2026
9 checks passed
@sgaczol sgaczol deleted the @sgaczol/android-paper-removal-misc branch April 2, 2026 13:39
@sgaczol sgaczol restored the @sgaczol/android-paper-removal-misc branch April 9, 2026 14:50
@sgaczol sgaczol deleted the @sgaczol/android-paper-removal-misc branch April 9, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants