Skip to content

refactor(tests): test-tabs-tab-bar-more-navigation-controller + scenario#3861

Open
LKuchno wants to merge 21 commits intomainfrom
@lkuchno/test-tabs-tab-bar-more-navigation-controller
Open

refactor(tests): test-tabs-tab-bar-more-navigation-controller + scenario#3861
LKuchno wants to merge 21 commits intomainfrom
@lkuchno/test-tabs-tab-bar-more-navigation-controller

Conversation

@LKuchno
Copy link
Copy Markdown
Collaborator

@LKuchno LKuchno commented Apr 9, 2026

Description

Moving test-tabs-tab-bar-more-navigation-controller into separate directory with scenario to it.

Closes: https://github.com/software-mansion/react-native-screens-labs/issues/1120

Changes

  • Screen moved into a new directory with a corresponding name, extended with '-tab-bar-'
  • Screen modification:
    - Fixed onMoreTabSelected toast message to display only 'onMoreTabSelected' instead of the full serialized event string.
    - Added onTabSelected handler emitting a blue toast with the selected tab's key.
  • New manual scenario created in the same directory covering different paths:
    - moving between More tab screen + tabs in it and tabs visible in tab bar normally,
    - check on navigation using buttons directly navigate to tabs
    - repeated More tab selection check
    - check on iPad when More tab is not displayed and when it is - scenario with app resizing

@LKuchno LKuchno added the area:tabs Issue related to bottom tabs label Apr 9, 2026
Copy link
Copy Markdown
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have few remarks. Let's resolve them before proceeding.

I have also a remark regarding naming. I think that more navigation controller has a broader scope than just tab bar, therefore I think that this rename is unnecessary here. What do you think?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we could add here test flows with resizing the app on iPad.

There is at least one more behaviour worth documenting.

When more navigation controller is selected on iPad (More list), and we resize the app, so that the "bottom tab bar" disappears, the previously selected tab is selected.

It would be ideal if we also were able to test navigation state updates in such case. Let's talk about this.

@LKuchno LKuchno requested a review from kkafar April 17, 2026 10:27
Copy link
Copy Markdown
Member

@kkafar kkafar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One remark - I have concerns regarding including console logs into the test scenario description.

This is mainly for one reason -> the logs are not stable, and they can be removed / added and I don't want this to break the tests.

I think direction here is to test effects only visible on the screen. If we need to react to some event, then we should show a toast / other visible UI element.

What do you think?

LKuchno and others added 2 commits April 20, 2026 10:12
…tion-controller/scenario.md

Co-authored-by: Kacper Kafara <kacper.kafara@swmansion.com>
@LKuchno
Copy link
Copy Markdown
Collaborator Author

LKuchno commented Apr 20, 2026

One remark - I have concerns regarding including console logs into the test scenario description.

This is mainly for one reason -> the logs are not stable, and they can be removed / added and I don't want this to break the tests.

I think direction here is to test effects only visible on the screen. If we need to react to some event, then we should show a toast / other visible UI element.

What do you think?

After discussion, I’m removing DevTools console validation due to log instability and high maintenance overhead. To compensate, I’m adding an onTabSelected toast to verify the behavior in edge cases.
Commit: 634c619

Repeated More tab selection added: f2d611a

@LKuchno LKuchno requested a review from kkafar April 20, 2026 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:tabs Issue related to bottom tabs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants