refactor(tests): test-tabs-tab-bar-more-navigation-controller + scenario#3861
refactor(tests): test-tabs-tab-bar-more-navigation-controller + scenario#3861
Conversation
…ns into @lkuchno/test-tabs-tab-bar-more-navigation-controller
kkafar
left a comment
There was a problem hiding this comment.
I have few remarks. Let's resolve them before proceeding.
I have also a remark regarding naming. I think that more navigation controller has a broader scope than just tab bar, therefore I think that this rename is unnecessary here. What do you think?
There was a problem hiding this comment.
I think we could add here test flows with resizing the app on iPad.
There is at least one more behaviour worth documenting.
When more navigation controller is selected on iPad (More list), and we resize the app, so that the "bottom tab bar" disappears, the previously selected tab is selected.
It would be ideal if we also were able to test navigation state updates in such case. Let's talk about this.
…ns into @lkuchno/test-tabs-tab-bar-more-navigation-controller
…ns into @lkuchno/test-tabs-tab-bar-more-navigation-controller
…ns into @lkuchno/test-tabs-tab-bar-more-navigation-controller
…ns into @lkuchno/test-tabs-tab-bar-more-navigation-controller
kkafar
left a comment
There was a problem hiding this comment.
One remark - I have concerns regarding including console logs into the test scenario description.
This is mainly for one reason -> the logs are not stable, and they can be removed / added and I don't want this to break the tests.
I think direction here is to test effects only visible on the screen. If we need to react to some event, then we should show a toast / other visible UI element.
What do you think?
…tion-controller/scenario.md Co-authored-by: Kacper Kafara <kacper.kafara@swmansion.com>
After discussion, I’m removing DevTools console validation due to log instability and high maintenance overhead. To compensate, I’m adding an onTabSelected toast to verify the behavior in edge cases. Repeated More tab selection added: f2d611a |
Description
Moving test-tabs-tab-bar-more-navigation-controller into separate directory with scenario to it.
Closes: https://github.com/software-mansion/react-native-screens-labs/issues/1120
Changes
- Fixed onMoreTabSelected toast message to display only 'onMoreTabSelected' instead of the full serialized event string.
- Added onTabSelected handler emitting a blue toast with the selected tab's key.
- moving between More tab screen + tabs in it and tabs visible in tab bar normally,
- check on navigation using buttons directly navigate to tabs
- repeated More tab selection check
- check on iPad when More tab is not displayed and when it is - scenario with app resizing