fix: render SVG on macOS Fabric by opting out of updateLayer#2941
Open
gabrieldonadel wants to merge 1 commit intosoftware-mansion:mainfrom
Open
fix: render SVG on macOS Fabric by opting out of updateLayer#2941gabrieldonadel wants to merge 1 commit intosoftware-mansion:mainfrom
gabrieldonadel wants to merge 1 commit intosoftware-mansion:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes SVG not rendering on macOS when the new arch is enabled. On macOS Fabric,
RNSVGSvgViewinherits fromRCTViewComponentView, which returnsYESfor-wantsUpdateLayer. WhenwantsUpdateLayerisYES, AppKit calls-updateLayerto set the layer's contents and skips-drawRect:entirely. SinceRNSVGSvgViewrenders all of its SVG content inside-drawRect:(viadrawToContext:withRect:), nothing was being painted on macOS new arch — the view stayed blank.Test Plan
Verified that SVGs render correctly on a macOS app with
RCT_NEW_ARCH_ENABLED=1. Without the fix the view paints nothing; with the fixdrawRect:is called and SVG content is drawn as expected.react-native-svgexample app on macOS with the New Architecture enabled.<Svg>(e.g. the basic shapes example).Compatibility
Checklist
README.md__tests__folder