Skip to content

Let implemented harvest settings inherit from base harvest settings #301

@sdruskat

Description

@sdruskat

When creating a UML class model to show an exemplary plugin implementation, I stumbled over this:

class CffHarvestSettings(BaseModel):

I believe that this should really be

from hermes.commands.harvest.base import HarvestSettings

class CffHarvestSettings(HarvestSettings): 
    ...

@led02 & @SKernchen: correct?

Metadata

Metadata

Assignees

No one assigned

    Labels

    architectureDescribes some architectural decisions that need to be madebugSomething isn't working

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions