💚 Update old Corepack that throw ENOTEMPTY or EPERM errors#198
Merged
sounisi5011 merged 33 commits intomasterfrom Mar 13, 2023
Merged
💚 Update old Corepack that throw ENOTEMPTY or EPERM errors#198sounisi5011 merged 33 commits intomasterfrom
sounisi5011 merged 33 commits intomasterfrom
Conversation
Old Corepack throws ENOTEMPTY error when running package managers in parallel. This has been fixed in Corepack v0.11, so if the old Corepack is detected, this will be updated.
The `mktemp` command on GitHub Actions seems to require the specification of the X's.
On Windows, the old Corepack seems to throw EPERM errors instead of ENOTEMPTY errors.
> ```yaml > # Windows installs global packages to a directory that has lower priority than > # the default node install so we also need to edit $PATH > ``` > Source: https://github.com/vercel/turbo/pull/1632/files#diff-b92a3120126a9ffe46d7d5ec3a8496ef1eac951db09e1972fac7c78438e36c42R62-R63 > ```bash > npm config get prefix >> $GITHUB_PATH > ``` > Source: https://github.com/vercel/turbo/pull/1632/files#diff-b92a3120126a9ffe46d7d5ec3a8496ef1eac951db09e1972fac7c78438e36c42R69
This step was added with #185. However, perhaps if we run `npm config get prefix >> "${GITHUB_PATH}"`, we can update npm with the `npm install --global npm` command.
…t variable `$PATH`
This reverts commit c9ddd9d.
…environment variable `$PATH`" This reverts commit 919029c.
…eep 1` command Waiting two seconds just to correct a display shift is a waste of time. Note: The POSIX-compliant `sleep` command has a minimum of one second, so we use the `node` command instead.
…t variable `$PATH`
…environment variable `$PATH`" This reverts commit 96914e1.
This reverts commit 70250e2.
…t variable `$PATH`
…environment variable `$PATH`" This reverts commit 481b3a0.
|
Code Climate has analyzed commit c90bef5 and detected 0 issues on this pull request. View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old Corepack throws ENOTEMPTY errors (or EPERM errors on Windows) when running package managers in parallel.
To fix this, update the old Corepack when it is detected.