This repository was archived by the owner on Sep 30, 2024. It is now read-only.
Re-enable experimental support for esbuild#28856
Merged
Conversation
github-actions
bot
added
the
frontend-platform
vovakulikov
approved these changes
Dec 13, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
esbuildwas removed in this PR: https://github.com/sourcegraph/sourcegraph/pull/28784 as it causedyarn installcommands to hang in CI.Solution
I thought this would be related to
postinstallas the dependency installed fine, it would only hang when building the dependencies at the final step of the command. This is quite difficult to debug as it only happens in CI (and will poison an agent if occurs), andyarndoesn't seem to output logs frompostinstallcommands.Upgrading
esbuildshould fix this, as it appears to have been a known bug that was recently fixed: evanw/esbuild#1621. Esbuild would try to fetch from the NPM registry directly which has been reported to hang in some environments.I have tested this by repeating the
yarn installcommands directly on a buildkite agent. Once I was confident that it did not cause the issue, I started (through normal CI) 50 runs ofyarn installacross different agents to double check - there were no failures.Closes https://github.com/sourcegraph/sourcegraph/issues/28785