Turn off race detection for upload test#1082
Merged
varungandhi-src merged 3 commits intomainfrom May 15, 2024
Merged
Conversation
bahrmichael
approved these changes
May 15, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having the tests be red on main is confusing. While we wait for stretchr/testify#1598
to land, I think it's best to turn off the bad test when running with the race detector.
So this PR moves the test to a different file which is only compiled with
go:build !race.I couldn't quite figure out how to run the single test without race detection while
running others with race detection, so I've temporarily added two
testcommandsin the
go-ci.ymlfile.Test plan
Covered by existing tests