Backport libxslt patch for CVE-2019-11068#1898
Merged
Merged
Conversation
related to USN-3947-1 and USN-3947-2. addresses #1892
|
Code Climate has analyzed commit fe034ae and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 100.0% (80% is the threshold). This pull request will bring the total coverage in the repository to 93.5%. View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem is this PR intended to solve?
Related to USN-3947-1 and USN-3947-2.
Addresses #1892
Have you included adequate test coverage?
No. Notably the upstream patch also has not added test coverage to libxslt. Imagine me making a judgmental face right now and you've probably nailed it.
Does this change affect the C or the Java implementations?
This affects the C implementation, and only when installing with the vendored version of libxslt; but not the Java implementation.