Merged
Conversation
Member
AlexVanderbist
left a comment
There was a problem hiding this comment.
Thanks for the PR! One thing worth addressing: packages/vite/src/index.ts imports OutputOptions from rollup (line 4), but Vite 8 replaces Rollup with Rolldown — so rollup is no longer available as a transitive dependency.
This won't break at runtime (the import is type-only and erased during compilation), but it will break type-checking and building from source once the repo's own vite devDependency is upgraded to 8.
Suggested fix — inline the type since only dir is used:
-import { OutputOptions } from 'rollup';
import { Plugin, ResolvedConfig, UserConfig } from 'vite';- async writeBundle(outputConfig: OutputOptions) {
+ async writeBundle(outputConfig: { dir?: string }) {This import relies on a transitive dependency. Vite 8 replaces rollup with rolldown, so this type check will break. By replacing it with an inlined type we prevent this.
Contributor
Author
|
Good catch @AlexVanderbist I've fixed it in bd6586d |
Member
|
Thanks, looks good! I'll merge this and tag it as a feature release 👍 |
Member
|
Tagged in 1.1.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Vite 8 is out: https://vite.dev/blog/announcing-vite8
Even though the migration guide is quite large, it doesn't seem that this project uses Vite except for types in one file so I don't think Vite 8 will break anything.