Add support for azure_key_vault KeyManager plugin in spire-server#780
Add support for azure_key_vault KeyManager plugin in spire-server#780dszakallas wants to merge 1 commit intospiffe:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds Helm chart configuration to enable SPIRE Server’s Azure Key Vault KeyManager plugin (azure_key_vault) via values and rendered server config.
Changes:
- Add
keyManager.azureKeyVaultconfiguration block tovalues.yaml. - Render an
azure_key_vaultKeyManager plugin stanza in the server config ConfigMap when enabled.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| charts/spire/charts/spire-server/values.yaml | Adds Azure Key Vault KeyManager values (enable flag + URI + identifier). |
| charts/spire/charts/spire-server/templates/configmap.yaml | Emits KeyManager: azure_key_vault plugin configuration when enabled. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| key_vault_uri: {{ .keyVaultURI }} | ||
| key_identifier_value: {{ .keyIdentifierValue }} |
There was a problem hiding this comment.
The rendered key_vault_uri and key_identifier_value are not quoted. Most other string plugin_data fields in this template are rendered with | quote, which avoids YAML parsing edge cases (URIs contain :/?) and keeps empty values as explicit strings. Consider quoting these values (and removing the extra space after key_vault_uri:) for consistency and safer rendering.
| key_vault_uri: {{ .keyVaultURI }} | |
| key_identifier_value: {{ .keyIdentifierValue }} | |
| key_vault_uri: {{ .keyVaultURI | quote }} | |
| key_identifier_value: {{ .keyIdentifierValue | quote }} |
| azureKeyVault: | ||
| ## @param keyManager.azureKeyVault.enabled Flag to enable keyManager in Azure Key Vault | ||
| enabled: false | ||
| ## @param keyManager.azureKeyVault.keyVaultURI Specify an URI for Azure Key Vault |
There was a problem hiding this comment.
Grammar in the parameter description: "Specify an URI" should be "Specify a URI".
| ## @param keyManager.azureKeyVault.keyVaultURI Specify an URI for Azure Key Vault | |
| ## @param keyManager.azureKeyVault.keyVaultURI Specify a URI for Azure Key Vault |
Add support for configuring the
azure_keyvaultKeyManager plugin for the spire server.