remove quotes from extracted font-family#177
Closed
Conversation
Owner
|
you forget others chars, like \t, \n, ... i think the best way is to use lines, to use the original trim default value can you update your PR ? i will add it directly on the master branch |
Owner
|
i close this PR. The 4.6 branch is not deprecated |
icebird93
pushed a commit
to EduBase/html2pdf
that referenced
this pull request
Jun 18, 2018
aaryarajojuH
added a commit
to aaryarajojuH/spipu
that referenced
this pull request
Feb 2, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #176
I did the modification on branch 4.6 because this is the version i use. I can edit my PR to target another branch, depending of your version policy.