Fix #287 hide technical exception messages in API error responses (SQL / Hibernate details)#302
Conversation
| import java.util.List; | ||
|
|
||
| import static org.hamcrest.Matchers.containsString; | ||
| import static org.hamcrest.Matchers.not; |
There was a problem hiding this comment.
@San-43 can you use AssertJ equivalents instead, pls?
we already have some mix of styles/test libraries, it will be good to stay with AssertJ by default.
There was a problem hiding this comment.
Hello @vfedoriv, thank you for your review, I'll be working on it.
There was a problem hiding this comment.
@San-43 can you use AssertJ equivalents instead, pls? we already have some mix of styles/test libraries, it will be good to stay with AssertJ by default.
Hi @vfedoriv, I updated the test to use AssertJ equivalents, removed unnecessary imports, and adjusted the logic as well, since I believe the previous version was not quite correct. Pls let me know if there's anything else that i should change.
ef8ac91 to
407f7ca
Compare
|
Thank you very much @vfedoriv for your review and for merging. It means a lot to me. |
This PR fixes issue #287.
I reproduced the issue locally, added tests, and implemented a fix.
Changes included:
testCreatePetSuccessto match the new logic.Please, let me know if there is anything wrong.