fix: validate owner-pet relationship in update endpoint#311
Open
sourav-18 wants to merge 2 commits intospring-petclinic:masterfrom
Open
fix: validate owner-pet relationship in update endpoint#311sourav-18 wants to merge 2 commits intospring-petclinic:masterfrom
sourav-18 wants to merge 2 commits intospring-petclinic:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #310
The endpoint PUT /owners/{ownerId}/pets/{petId} allowed updating pets that do not belong to the specified owner.
This PR adds validation to ensure that the pet being updated belongs to the given owner:
This approach keeps the
serviceandrepositorylayers unchanged and introduces a minimal fix at the controller level.An alternative approach could be to validate ownership at the repository level using a method like
findPetByIdAndOwnerId, but the current solution avoids additional changes and resolves the issue effectively.