Skip to content

Spring Boot 3 does not provide a configuration property for configuring red metrics custom tag keys #34194

@ttddyy

Description

@ttddyy

In WavefrontTracingAutoConfiguration, it defines a WavefrontSpanHandler bean.
This passes an empty collection to the redMetricsCustomTagKeys in the constructor.

@Bean
@ConditionalOnMissingBean
@ConditionalOnBean(WavefrontSender.class)
WavefrontSpanHandler wavefrontSpanHandler(WavefrontProperties properties, WavefrontSender wavefrontSender,
SpanMetrics spanMetrics, ApplicationTags applicationTags) {
return new WavefrontSpanHandler(properties.getSender().getMaxQueueSize(), wavefrontSender, spanMetrics,
properties.getSourceOrDefault(), applicationTags, Collections.emptySet());
}

Per this documentation in Wavefront, the redMetricsCustomTagKeys should be populated by the wavefront.tracing.red-metrics-custom-tag-keys property.
I believe this bean definition is the corresponding part for the property.

So, what the doc mentioned to work, I think populated values need to be passed to redMetricsCustomTagKeys rather than an empty set.

Metadata

Metadata

Assignees

Labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions