Register Printer<T> and Parser<T> beans as converters#17064
Closed
nosan wants to merge 1 commit intospring-projects:masterfrom
Closed
Register Printer<T> and Parser<T> beans as converters#17064nosan wants to merge 1 commit intospring-projects:masterfrom
nosan wants to merge 1 commit intospring-projects:masterfrom
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
nosan
force-pushed
the
gh-16171
branch
4 times, most recently
from
7ae0f88 to
0fb801a
Compare
philwebb
added
type: enhancement
Member
|
I raise spring-projects/spring-framework#23110 to see if we can't improve Spring Framework first. It's a bit nasty that we need new |
philwebb
added
the
status: blocked
philwebb
pushed a commit
that referenced
this pull request
Jun 13, 2019
Update `WebMvcAutoConfiguration` and `WebFluxAutoConfiguration` so that `Printer<T>` and `Parser<T>` beans are automatically registered with the conversion service. Prior to this commit only `GenericConverter`, `Converter` and `Formatter` beans were automatically registered. See gh-17064
philwebb
added a commit
that referenced
this pull request
Jun 13, 2019
Extract common registration code and make use of the Spring Framework registration methods. See gh-17064
Member
|
Thanks for the PR @nosan! This is now in master. With the spring-projects/spring-framework#23110 change I've been able to simplify it as we no longer need our own |
Contributor
Author
|
Thank you very much @philwebb |
wilkinsona
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Registers
Printer<T>andParser<T>as converters if they have been exposed as beans.see gh-16171