Add boundary tests for JsonValueWriter max nesting depth#49662
Merged
wilkinsona merged 2 commits intospring-projects:3.5.xfrom Mar 19, 2026
Merged
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
wilkinsona
reviewed
Mar 19, 2026
Comment on lines
+316
to
+328
| @Test | ||
| void shouldRejectStartingObjectWhenCurrentDepthExceedsMaxDepth() { | ||
| StringBuilder out = new StringBuilder(); | ||
| JsonValueWriter writer = new JsonValueWriter(out, 2); | ||
|
|
||
| writer.start(Series.OBJECT); | ||
| writer.start(Series.OBJECT); | ||
| writer.start(Series.OBJECT); | ||
|
|
||
| assertThatIllegalStateException().isThrownBy(() -> writer.start(Series.OBJECT)) | ||
| .withMessageContaining("JSON nesting depth (3)") | ||
| .withMessageContaining("exceeds maximum depth of 2"); | ||
| } |
Member
There was a problem hiding this comment.
This test doesn't seem to add much as the exception case is covered by the existing tests. Why do you feel it's needed?
Comment on lines
+346
to
+358
| @Test | ||
| void shouldRejectStartingArrayWhenCurrentDepthExceedsMaxDepth() { | ||
| StringBuilder out = new StringBuilder(); | ||
| JsonValueWriter writer = new JsonValueWriter(out, 2); | ||
|
|
||
| writer.start(Series.ARRAY); | ||
| writer.start(Series.ARRAY); | ||
| writer.start(Series.ARRAY); | ||
|
|
||
| assertThatIllegalStateException().isThrownBy(() -> writer.start(Series.ARRAY)) | ||
| .withMessageContaining("JSON nesting depth (3)") | ||
| .withMessageContaining("exceeds maximum depth of 2"); | ||
| } |
Member
There was a problem hiding this comment.
This test doesn't seem to add much as the exception case is covered by the existing tests. Why do you feel it's needed?
Contributor
Author
|
Thanks for the feedback. The intention of these tests was to exercise the max nesting depth check However, I agree that this overlaps with the existing coverage, so I’ve removed Please let me know if further adjustments would be helpful. |
wilkinsona
added
type: task
Verify behavior at the maxNestingDepth boundary. Signed-off-by: Joowon-Seo <[email protected]> See spring-projectsgh-49662
wilkinsona
force-pushed
the
test/json-value-writer-nesting-boundary
branch
from
0a96475 to
7f0136f
Compare
wilkinsona
pushed a commit
to Joowon-Seo/spring-boot
that referenced
this pull request
Mar 19, 2026
Verify behavior at the maxNestingDepth boundary. Signed-off-by: Joowon-Seo <[email protected]> See spring-projectsgh-49662
wilkinsona
force-pushed
the
test/json-value-writer-nesting-boundary
branch
from
7f0136f to
5679882
Compare
wilkinsona
force-pushed
the
test/json-value-writer-nesting-boundary
branch
from
5679882 to
3717468
Compare
Member
|
Thank you, @Joowon-Seo. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change adds boundary tests for JsonValueWriter max nesting depth.
Existing tests verify that exceeding the maximum depth eventually results
in an exception, but they do not assert the exact boundary at which nesting
is still allowed.
The new tests verify that starting a new series when the current depth
equals maxNestingDepth is still allowed, and that an exception is thrown
when attempting to start another series beyond that point.
This helps to better define the current behavior and guard against regressions.