Add @ConditionalOnWebApplication to NettyReactiveWebServerAutoConfiguration#49695
Closed
kwondh5217 wants to merge 1 commit intospring-projects:mainfrom
Closed
Add @ConditionalOnWebApplication to NettyReactiveWebServerAutoConfiguration#49695kwondh5217 wants to merge 1 commit intospring-projects:mainfrom
kwondh5217 wants to merge 1 commit intospring-projects:mainfrom
Conversation
…ration Signed-off-by: Daeho Kwon <[email protected]>
spring-projects-issues
added
the
status: waiting-for-triage
philwebb
added
type: regression
philwebb
pushed a commit
that referenced
this pull request
Mar 21, 2026
…ration See gh-49695 Signed-off-by: Daeho Kwon <[email protected]>
Member
|
Thanks very much @kwondh5217. For future reference, if you create PR from a new branch, rather than |
Contributor
Author
|
Thanks @philwebb !I'll make sure to create PRs from a new branch next time. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #49693.
NettyReactiveWebServerAutoConfigurationis missing a@ConditionalOnWebApplication(type = Type.REACTIVE)condition, unlike other reactive web server auto-configurations such asJettyReactiveWebServerAutoConfiguration.Closes #49693