Potential throwing of the blocking exception

[AntonLGVS]

In the DefaultReactiveElasticsearch class there is a call to block(). This could potentially cause the IllegalStateException("block()/blockFirst()/blockLast()...) to be thrown. This will be thrown into EventLoop of the Netty Server.
Can make a reactive implementation of the SearchDocumentResponse to remove the blocking call?

[sothawo]

where exactly in which class?

[AntonLGVS]

class ReactiveElasticsearchTemplate:

line 805: Function<SearchDocument, Object> entityCreator = searchDocument -> documentCallback.toEntity(searchDocument)
line 806:     .block();

[sothawo]

I'll have to have a deeper look at this callback, but I think that the reactive version of this callback is not needed here anyway and this could be a non-reactive call.

[AntonLGVS]

Maybe change the callback to a non-reactive version? I can do it.

[sothawo]

The non-reactive code has some callback for this as well, this should be used or consolidated into common code.

[AntonLGVS]

The callback ReadSearchDocumentCallback has a call to the maybeCallAfterConvert public API.
There are solution options:

1. Implementation of the reactive SearchDocumentResponse;
2. Calling the maybeCallAfterConvert method outside the ReadSearchDocumentCallback#toEntity method, but then we need to change the signature of the ReadSearchDocumentCallback#toEntity and return a wrapper with parameters for the maybeCallAfterConvert method. A rough example:

Wrapper wr = toEntity(...);
maybeCallAfterConvert(wr.p1(), wr.p2(),.....);

[sothawo]

I'll hopefully have a look at this deeper in the next days currently I'm quite busy (not doing this as my day job 😃 )

[AntonLGVS]

I'am know that is a free time job. Me too. I have the opportunity to help you develop this project.