Support for Hibernate 6

[odrotbohm]

[odrotbohm]

The current state of affairs can be found in hacking/hibernate-6. Currently failing as Querydsl JPA throwing a NullPointerException from JPAUtil.setConstants(…):

[ERROR] Failures: 
[ERROR]   QuerydslJpaPredicateExecutorUnitTests.findByFluentPredicateOneValue:369 
Expecting actual throwable to be an instance of:
  org.springframework.dao.IncorrectResultSizeDataAccessException
but was:
  java.lang.NullPointerException: Cannot invoke "org.hibernate.query.BindableType.getBindableJavaType()" because "this.anticipatedType" is null
	at org.hibernate.query.spi.AbstractQueryParameter.getParameterType(AbstractQueryParameter.java:61)
	at com.querydsl.jpa.impl.JPAUtil.setConstants(JPAUtil.java:53)
	at com.querydsl.jpa.impl.AbstractJPAQuery.createQuery(AbstractJPAQuery.java:133)
	...(79 remaining lines not displayed - this can be changed with Assertions.setMaxStackTraceElementsDisplayed)
[ERROR]   QuerydslJpaPredicateExecutorUnitTests.findOneWithPredicateThrowsExceptionForNonUniqueResults:329 
Expecting actual throwable to be an instance of:
  org.springframework.dao.IncorrectResultSizeDataAccessException
but was:
  java.lang.NullPointerException: Cannot invoke "org.hibernate.query.BindableType.getBindableJavaType()" because "this.anticipatedType" is null
	at org.hibernate.query.spi.AbstractQueryParameter.getParameterType(AbstractQueryParameter.java:61)
	at com.querydsl.jpa.impl.JPAUtil.setConstants(JPAUtil.java:53)
	at com.querydsl.jpa.impl.AbstractJPAQuery.createQuery(AbstractJPAQuery.java:133)
	...(76 remaining lines not displayed - this can be changed with Assertions.setMaxStackTraceElementsDisplayed)

[odrotbohm]

Actually, it looks like the NPE is caused by Hibernate in the first place.

[odrotbohm]

Other issues currently found (updated continuously):

• HibernateJpaDialect compatibility with Hibernate 6 (read-only transactions etc) spring-framework#28007
• HHH-15071 – Resolved in 6.0 CR2, also reported in Support for Hibernate 6 querydsl/querydsl#3166.
• HibernateJpaParametersParameterAccessor (originally introduced for Support TypedParameterValue of hibernate-orm #2366 and Improvements to clarify type using TypedParameterValue #2370) used SessionFactory.getTypeHelper() which was removed in 6.0 without prior notice. Also, TypeHelper is deprecated without replacement in 6. It looks like there's alternative API being introduced, but the static factory methods in BindableType (required to construct a TypedParameterValue now) still throw NotYetImplementedFor6Exception in CR2. 😕

Related but not crucial:

• HHH-15070 – EmbeddedInstantiator not considered for embedded ids when resolving related collections (dedicated reproducer coming)

[odrotbohm]

Assigning Jens to investigate the impact of the changes regarding HibernateJpaParametersParameterAccessor.

[MSDehghan]

Just to note, The final version of Hibernate 6.0 is released by now.
https://in.relation.to/2022/03/31/orm-60-final/

[heowc]

It's not exact, but I think you can change it like this 🤔 :

BindableType<?> bindableType = entityManager.getEntityManagerFactory()
                                            .unwrap(SessionFactoryImplementor.class)
                                            .resolveParameterBindType(parameter.getType());
new TypedParameterValue(bindableType, null);

[Rob4001]

I think this may be what you are looking for:

class HibernateJpaParametersParameterAccessor extends JpaParametersParameterAccessor {

	private final BasicTypeRegistry typeHelper;

	/**
	 * Creates a new {@link ParametersParameterAccessor}.
	 *
	 * @param parameters must not be {@literal null}.
	 * @param values must not be {@literal null}.
	 * @param em must not be {@literal null}.
	 */
	HibernateJpaParametersParameterAccessor(Parameters<?, ?> parameters, Object[] values, EntityManager em) {

		super(parameters, values);

		Session session = em.unwrap(Session.class);
		SessionFactoryImplementor sessionFactory = session.getSessionFactory().unwrap(SessionFactoryImplementor.class);
		typeHelper = sessionFactory.getTypeConfiguration().getBasicTypeRegistry();
	}

	@Override
	public Object getValue(Parameter parameter) {

		Object value = super.getValue(parameter.getIndex());
		if (value != null) {
			return value;
		}

		var type = typeHelper.getRegisteredType(parameter.getType());
		if (type == null) {
			return null;
		}
		return new TypedParameterValue<>(type, null);
	}
}

[odrotbohm]

After the releases of 6.0 and 6.0.1 Final we run into a couple of new issues:

• NullPointerExceptions from CompleteResultBuilderBasicValuedStandard.getJavaType(…) when executing named native queries, triggered by NativeQueryImpl(…).
• INVALID (see below):Rejection of query arrangements we currently prepare that are rightfully considered invalid
  • Delete queries not set up as such but being simple queries eventually executed through EntityManager.delete(…).
  • Count queries currently select based on the root type but apply a count projection. We can move to always select a Long there.