DATAREDIS-1140 - Add support to Redis Streams using Jedis Client#1977
Closed
dengliming wants to merge 4 commits intospring-projects:masterfrom
Closed
DATAREDIS-1140 - Add support to Redis Streams using Jedis Client#1977dengliming wants to merge 4 commits intospring-projects:masterfrom
dengliming wants to merge 4 commits intospring-projects:masterfrom
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
dengliming
changed the title
mp911de
reviewed
Feb 18, 2021
Member
mp911de
left a comment
mp911de
left a comment
There was a problem hiding this comment.
Thank you for your contribution, great work. I left a few comments, mostly high-level aspects. Care to have a look?
| maxLength = options.getMaxlen(); | ||
| } | ||
|
|
||
| return connection.invoke().from(BinaryJedis::xadd, MultiKeyPipelineBase::xadd, record.getStream(), id, |
Member
There was a problem hiding this comment.
Good work, we introduced the invoker just recently.
mp911de
added
type: enhancement
mp911de
added a commit
that referenced
this pull request
Mar 16, 2021
Add support for Jedis Streams using JedisCluster. Add fromMany(…) for non-pipelined usage to JedisInvoker. Reformat code, add author tags. Extract Jedis-specific stream type converters to StreamConverters. Properly convert StreamEntry and StreamEntryID into list/map. Update tests. See #1711 Original pull request: #1977.
Member
|
Thank you for your contribution. That's merged and polished now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
resolves #1711