Skip to content

Support @Import on interfaces#34820

Closed
kwondh5217 wants to merge 3 commits intospring-projects:mainfrom
kwondh5217:main
Closed

Support @Import on interfaces#34820
kwondh5217 wants to merge 3 commits intospring-projects:mainfrom
kwondh5217:main

Conversation

@kwondh5217
Copy link
Copy Markdown
Contributor

@kwondh5217 kwondh5217 commented Apr 24, 2025

Closes gh-34805

@kwondh5217
Support @Import on interfaces
6ff1e2d 
Closes spring-projectsgh-34805

Signed-off-by: Daeho Kwon <trewq231@naver.com>
@spring-projects-issues spring-projects-issues added the status: waiting-for-triage An issue we've not yet triaged or decided on label Apr 24, 2025
@bclozel bclozel added the in: core Issues in core modules (aop, beans, core, context, expression) label Jun 3, 2025
@sbrannen sbrannen self-assigned this Jun 3, 2025
@sbrannen sbrannen added type: enhancement A general enhancement and removed status: waiting-for-triage An issue we've not yet triaged or decided on labels Jun 3, 2025
@sbrannen sbrannen added this to the 7.0.0-M6 milestone Jun 3, 2025
sbrannen
sbrannen requested changes Jun 3, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sbrannen sbrannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

I've requested a few changes.

@sbrannen sbrannen mentioned this pull request Jun 3, 2025
Closed
@kwondh5217 kwondh5217 requested a review from sbrannen June 3, 2025 15:13
@kwondh5217
Copy link
Copy Markdown
Contributor Author

kwondh5217 commented Jun 3, 2025

@sbrannen Thanks for the review!
I’ve updated the code as suggested and added the test.
Please take another look when you have time 🙇

@kwondh5217
Adjust @Import processing to prioritize local declarations
a3dd3d2 
Closes spring-projectsgh-34805

Signed-off-by: Daeho Kwon <trewq231@naver.com>
sbrannen
sbrannen requested changes Jun 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sbrannen sbrannen left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making the requested changes!

I've added an additional request to revise the "local @Import" use case.

Please also update the copyright header in ImportSelectorTests.

Thanks

@sbrannen sbrannen added the status: waiting-for-feedback We need additional information before we can continue label Jun 4, 2025
@kwondh5217
Add @Import to OverridingConfig
fdbfa3e 
Closes spring-projectsgh-34805

Signed-off-by: Daeho Kwon <trewq231@naver.com>
@kwondh5217
Copy link
Copy Markdown
Contributor Author

kwondh5217 commented Jun 4, 2025

Thanks for the guidance, @sbrannen.
I’ve pushed the update with @Import on OverridingConfig.
Please take another look when you have time

@kwondh5217 kwondh5217 requested a review from sbrannen June 4, 2025 12:04
@spring-projects-issues spring-projects-issues added status: feedback-provided Feedback has been provided and removed status: waiting-for-feedback We need additional information before we can continue labels Jun 4, 2025
@sbrannen sbrannen removed the status: feedback-provided Feedback has been provided label Jun 4, 2025
sbrannen
sbrannen approved these changes Jun 4, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@sbrannen sbrannen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

Thanks for making all of the requested changes.

@sbrannen sbrannen closed this in a4d5800 Jun 4, 2025
sbrannen added a commit that referenced this pull request Jun 4, 2025
@sbrannen
Polish support for @⁠Import on interfaces
4581324 
- Update @⁠Import Javadoc

- Move tests from ImportSelectorTests to ImportTests

See gh-34820
@sbrannen
Copy link
Copy Markdown
Member

sbrannen commented Jun 4, 2025

This has been merged into main in a4d5800 and slightly revised in 4581324.

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sbrannen sbrannen sbrannen approved these changes

Assignees

@sbrannen sbrannen

Labels

in: core Issues in core modules (aop, beans, core, context, expression) type: enhancement A general enhancement

Projects

None yet

Milestone

7.0.0-M6

Development

Successfully merging this pull request may close these issues.

Consider implemented interfaces during @Import processing

4 participants

@kwondh5217 @sbrannen @bclozel @spring-projects-issues
⚡