Skip to content

Fixed a bug where an error in a proof verification allowed a positive…#527

Open
vdods wants to merge 1 commit into
spruceid:mainfrom
LedgerDomain:fix-credential-verify-bug
Open

Fixed a bug where an error in a proof verification allowed a positive…#527
vdods wants to merge 1 commit into
spruceid:mainfrom
LedgerDomain:fix-credential-verify-bug

Conversation

@vdods

@vdods vdods commented Aug 16, 2023

Copy link
Copy Markdown
Contributor

… Check::Proof to be added to the verification results in addition to the expected error. This fixes it to match the analogous logic in other proof verification code.

… Check::Proof to be added to the verification results in addition to the expected error. This fixes it to match the analogous logic in other proof verification code.
@vdods

vdods commented Aug 16, 2023

Copy link
Copy Markdown
Contributor Author

This only required fixing a typo. The bug in particular was that I was seeing

VerificationResult { checks: [Proof], warnings: [], errors: [ "signature error: Verification equation was not satisfied" ] }

when I should have been seeing

VerificationResult { checks: [], warnings: [], errors: [ "signature error: Verification equation was not satisfied" ] }

@CLAassistant

CLAassistant commented Jul 23, 2024

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@vdods

vdods commented Aug 20, 2024

Copy link
Copy Markdown
Contributor Author

Same deal here, I sent in a signed CLA Oct 6, 2021, but let me know if you need a new one for whatever reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants