Variadics not recognized by tokenizer

[aurora]

It seems that variadics -- available in php since 5.6 -- are not recognized by the tokenizer. For example for the line of code:

public function enum($value, ...$items)

i get the following wrong error message (PSR-2 standard):

Expected 1 space between comma and argument "$items"; 0 found

[gsherwood]

From PHP 5.6, PHPCS will see ... as a T_ELLIPSIS token. Before that, there will just be 3 . tokens in a row. But I'll have a look at emulating T_ELLIPSIS in PHP versions < 5.6, like I do for some other token types.

But the error message you are getting is a problem with one of the sniffs rather than the tokenizer. It's possible others may need to change as well, so I'll do a but of a review at the same time. Will take longer, but hopefully I'll get them all.

[gsherwood]

I've committed the fix for this now. In all PHP versions, ... will be tokenized as T_ELLIPSIS.

I only found 1 other sniff that was having a problem; the one that checked that arguments with default values come at the end of the list.

[aurora]

Thanks a lot!

[bkdotcom]

almost... still an issue when passing by reference

expected 1 space between comma and argument "$moreParams"; 0 found

/**
 * Variadic passed by reference
 *    https://wiki.php.net/rfc/variadics#by-reference_capture
 */
function methodProtected($param, &...$moreParams) {
}

I've opened issue #332