You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Enforce no spaces before closing brackets and also add test cases.
There's some duplicate code around setting up eslint.CLIEngine in the tests which I hope to improve in a separate PR so this PR is focused only on the linked issue above.
@tewsonseeoun-toast For standard v14, I started a new system for adding rules. I'd like to put all new rules into the eslintrc.json file there until it's time to release the next major version. At the time that I cut the official v14.0.0 release, I will move all these rules out into the respective shared eslint configs (like this repo).
This makes it much easier to do a beta release of standard since I don't need to do beta releases of the eslint config repos too and then bump all the versions together.
I kept this PR open so I can merge it when it's time :) But in the future, I would direct PRs to the main standard/standard repo.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes standard/standard#1348.
Enforce no spaces before closing brackets and also add test cases.
There's some duplicate code around setting up
eslint.CLIEnginein the tests which I hope to improve in a separate PR so this PR is focused only on the linked issue above.