Skip to content

Enforce no spaces before closing brackets#38

Merged
feross merged 1 commit intostandard:masterfrom
tewsonseeoun-toast:disallow-space-closing-bracket-opening-tag
Aug 14, 2019
Merged

Enforce no spaces before closing brackets#38
feross merged 1 commit intostandard:masterfrom
tewsonseeoun-toast:disallow-space-closing-bracket-opening-tag

Conversation

@tewsonseeoun-toast
Copy link
Copy Markdown
Contributor

@tewsonseeoun-toast tewsonseeoun-toast commented Aug 1, 2019 •
edited by feross
Loading

Fixes standard/standard#1348.

Enforce no spaces before closing brackets and also add test cases.

There's some duplicate code around setting up eslint.CLIEngine in the tests which I hope to improve in a separate PR so this PR is focused only on the linked issue above.

LinusU
LinusU approved these changes Aug 1, 2019
View reviewed changes
Copy link
Copy Markdown
Member

@LinusU LinusU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat 👍

feross added a commit to standard/standard that referenced this pull request Aug 3, 2019
@feross
JSX: Enforce no spaces before closing brackets (i.e. no <div > or `…
a269c99 
…</div >`)

Fixes: #1348
For: standard/eslint-config-standard-jsx#38
@feross
Copy link
Copy Markdown
Member

feross commented Aug 3, 2019

This will be part of standard v14

@tewsonseeoun-toast
Copy link
Copy Markdown
Contributor Author

tewsonseeoun-toast commented Aug 6, 2019

@feross Does this mean further pull requests should be opened in https://github.com/standard/standard instead?

@feross
Copy link
Copy Markdown
Member

feross commented Aug 6, 2019 •
edited
Loading

@tewsonseeoun-toast For standard v14, I started a new system for adding rules. I'd like to put all new rules into the eslintrc.json file there until it's time to release the next major version. At the time that I cut the official v14.0.0 release, I will move all these rules out into the respective shared eslint configs (like this repo).

This makes it much easier to do a beta release of standard since I don't need to do beta releases of the eslint config repos too and then bump all the versions together.

I kept this PR open so I can merge it when it's time :) But in the future, I would direct PRs to the main standard/standard repo.

@tewsonseeoun-toast
Copy link
Copy Markdown
Contributor Author

tewsonseeoun-toast commented Aug 7, 2019

@feross That's fair enough. Thank you for the explanation!

@feross feross merged commit d6dc575 into standard:master Aug 14, 2019
@tewsonseeoun-toast tewsonseeoun-toast deleted the disallow-space-closing-bracket-opening-tag branch August 14, 2019 08:48
suchitg8 pushed a commit to suchitg8/standard that referenced this pull request Apr 9, 2022
@feross
JSX: Enforce no spaces before closing brackets (i.e. no <div > or `…
cfe0900 
…</div >`)

Fixes: standard/standard#1348
For: standard/eslint-config-standard-jsx#38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@LinusU LinusU LinusU approved these changes

Assignees

No one assigned

Labels

None yet

Projects

The Standard Project
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Enforce consistent JSX opening tag spacing

3 participants

@tewsonseeoun-toast @feross @LinusU
⚡