Conversation
mightyiam
left a comment
There was a problem hiding this comment.
From my supposedly common sense, any rule change in this package is breaking. The peerDep as well.
In the standard package, this would not be a breaking change, if the rules behave the same. Since it would be too much work to guarantee this, I would simply mark it as a breaking change there, as well.
Did you go over each rule and see that they don't take new options or have different defaults or anything else that would alter the behavior from the deprecated core ESLint rules?
|
Well merge this together with #170 and bump the major version 👍
According to the release notes, the rules were simply copied from core: |
This should (probably, right?) be a breaking change since we are changing a peer dependency.