JSX but not React in scope

[HenrikJoreteg]

I'm using JSX syntax to generate virtual-dom/h code using babel plugins (this specifically).

Only problem is, now standard complains because React is not in scope.

Not quite sure how this should be addressed, however. Because that check is useful when using React.

[HenrikJoreteg]

Perhaps it'd just be best to remove that rule? Not having React in scope will blow up pretty quickly. That's doesn't seems like something that would cause subtle bugs, it just blows up :)

[jprichardson]

Why not just disable it for your use case?

Put this at the top of your file:

/* eslint-disable react-in-jsx-scope */

[feross]

@jprichardson Wouldn't disabling the rule be friendlier for people using React competitors like Riot and Deku? I don't really want to be opinionated and push people to React without a good reason.

[jprichardson]

@feross yep.

I don't really want to be opinionated and push people to React without a good reason.

Alright, fair enough. While it's nice to have the live feedback in my IDE (linter-js-standard) when I forget to add React with JSX, I definitely understand this perspective and don't have a strong feeling either way.

[dcousens]

This error is almost impossible to miss, as the code simply will fail at require time in almost all cases.
I'm OK with it being disabled.

[feross]

@HenrikJoreteg want to send a PR?

[HenrikJoreteg]

Sure, will do
On Wed, Dec 2, 2015 at 19:00 Feross Aboukhadijeh notifications@github.com
wrote:

@HenrikJoreteg https://github.com/HenrikJoreteg want to send a PR?

—
Reply to this email directly or view it on GitHub
#351 (comment).

[HenrikJoreteg]

Didn't know if you need anything else in terms or tests or whatnot. Just tweaked the config in the other module? Just lemme know if i missed something.

[HenrikJoreteg]

it does raise an interesting question, however. Now what happens to the h that's an unused variable?

[feross]

@HenrikJoreteg So, now you get an unused variable warning?

[HenrikJoreteg]

right

[dcousens]

I merged that change, but, we can roll it back if necesssary.

If h is undefined, then, you should global it out IMHO.