Skip to content

fix(presentation): dedupe duplicate main metric columns#4217

Open
MukundaKatta wants to merge 1 commit intostanford-crfm:mainfrom
MukundaKatta:codex/helm-dedupe-main-metric
Open

fix(presentation): dedupe duplicate main metric columns#4217
MukundaKatta wants to merge 1 commit intostanford-crfm:mainfrom
MukundaKatta:codex/helm-dedupe-main-metric

Conversation

@MukundaKatta
Copy link
Copy Markdown

Summary

  • dedupe substituted metric matchers in create_group_table so a scenario main metric does not render twice when it also appears in another metric group
  • add a regression test covering main_metric plus an explicit accuracy group resolving to the same metric column

Testing

  • python3 -m compileall src/helm/benchmark/presentation/summarize.py src/helm/benchmark/presentation/test_summarize.py
  • tried PYTHONPATH=/tmp/helm-user/src python3 -m pytest /tmp/helm-user/src/helm/benchmark/presentation/test_summarize.py -k deduplicates_main_metric_columns
  • local pytest startup was blocked because this environment is missing cattrs (ModuleNotFoundError: No module named 'cattrs')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant