StRoot/StUtilities/StMessage: fix regression from using the proper std::ostringstream::str#168
Merged
plexoos merged 3 commits intostar-bnl:mainfrom Oct 11, 2021
Merged
Conversation
This partially reverts fdb863a ('Initialize and test ostrstream buffer sizes (support for gcc before 3.2)')
Member
Author
|
Basically the regression is due to change in the meaning of the following line: star-sw/StRoot/StUtilities/StMessage.cxx Line 131 in 0ccfbd3 Previously it was printing a NULL-terminated string from a char* and now it works with a string of a know length, an std::string.
|
veprbl
changed the title
plexoos
approved these changes
Oct 8, 2021
genevb
reviewed
Oct 8, 2021
Contributor
genevb
left a comment
genevb
left a comment
There was a problem hiding this comment.
I'm not really paying close attention to the modifications being made to the message management, but I see that github requires me to at least submit a comment. Doing so here so that I'm not an obstacle to the effort.
The .str().c_str() is safe to use within a single expression, but saving a pointer would be an UB. This issue was found using valgrind.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #165
Closes: #166