Merged
Conversation
- Implement first cut of the y2022 geometry @ timestamp 20211010.000000 -- sTGC and forward silicon detectors are still in development -- overlaps are a concern for the initial geometries -- expecting geometry updates end of month timescale - Remove deprecated dev2021 geometry model - Advance dev2022 timestamp by 100 years to not interfere
Contributor
Author
|
S&C Management Meeting discussion, it is time to create the y2022 first cut geometry. |
Contributor
|
I see that we did the 15th of the month in the past for the geometry timestamp (the 10th of the month was for development?). So perhaps we should set it to 20211015? |
Contributor
|
Jason if yu removed dev2021 which is fine, we need to discuss how to do simplified vs. ful geometry. Can be talk on Friday (I am busy tih DNP tomorrow) F |
Contributor
Author
|
@genevb I suppose consistency would be nice here. I'll update to the 15th. @fvidebaek Good point. The reason I removed dev2021 was to avoid a conflict with timestamps... but I can do the same trick as with dev2022. Codes will be pushed later this evening. |
fvidebaek
reviewed
Oct 14, 2021
| <Construct sys="hcal" config="HCALv1" simu="1" /> | ||
| <Construct sys="plat" config="PLATon" simu="2" /> | ||
| <Construct sys="pres" config="PRESof" simu="2" /> | ||
| <!-- Note: These versions of the forward trackers have significant overlaps which need to be resolved --> |
Contributor
There was a problem hiding this comment.
Not quite sure I understand the overlap comment for FSTMv1. I agree that the STGCv1 is not correct. It is being worked on.
Contributor
Author
|
Mainly a warning / reminder to myself that these detector models need to
be updated.
Agreed, sTGC is the main concern.
…On 2021-10-14 15:24, fvidebaek wrote:
@fvidebaek commented on this pull request.
-------------------------
In StarVMC/Geometry/StarGeo.xml [1]:
> <Construct sys="wcal" config="WCALv1" simu="1" />
<Construct sys="hcal" config="HCALv1" simu="1" />
- <Construct sys="plat" config="PLATon" simu="2" />
- <Construct sys="pres" config="PRESof" simu="2" />
+ <!-- Note: These versions of the forward trackers have
significant overlaps which need to be resolved -->
Not quite sure I understand the overlap comment for FSTMv1. I agree
that the STGCv1 is not correct. It is being worked on.
--
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub [2], or unsubscribe
[3].
Triage notifications on the go with GitHub Mobile for iOS [4] or
Android [5].
Links:
------
[1] #173 (comment)
[2]
#173 (review)
[3]
https://github.com/notifications/unsubscribe-auth/ANL4LVA5R2EKGKSXNMKQFS3UG4U7RANCNFSM5F5ZA7WA
[4]
https://urldefense.com/v3/__https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675__;!!P4SdNyxKAPE!SUKueiybJFuR_DxvJ4ygNwDcaRCuodz7l3C_C_L8gDYB95yi9E6UQqwPmgoviXY$
[5]
https://urldefense.com/v3/__https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign*3Dnotification-email*26utm_medium*3Demail*26utm_source*3Dgithub__;JSUlJSU!!P4SdNyxKAPE!SUKueiybJFuR_DxvJ4ygNwDcaRCuodz7l3C_C_L8gDYB95yi9E6UQqwPR33w2FQ$
|
fvidebaek
reviewed
Oct 18, 2021
| {"dev2021", 20221210, 0, "dev2021", "-deprecated- geometry for 2021+ forward program,AgML,xgeometry"}, | ||
| {"dev2022", 20221210, 1, "dev2022", "development geometry for 2022+ forward program,AgML,xgeometry"}, | ||
|
|
||
| {"y2022", 20211010, 0, "y2021", "y2021 development geometry, AgML,xgeometry"}, |
Contributor
There was a problem hiding this comment.
line 159 - shouldn't the 2 last y2021 be 2022 ?
Contributor
Author
There was a problem hiding this comment.
Yes it should... also, missed an update on xgeometry which is now in place.
Contributor
Author
There was a problem hiding this comment.
Clearly haven't had enough coffee today...
fvidebaek
reviewed
Oct 18, 2021
Contributor
fvidebaek
left a comment
fvidebaek
left a comment
There was a problem hiding this comment.
question on line 159 . in .age
fvidebaek
approved these changes
Oct 18, 2021
genevb
approved these changes
Oct 19, 2021
Contributor
genevb
left a comment
genevb
left a comment
There was a problem hiding this comment.
I am not reviewing most of what is being changed here, but I will approve the addition of y2022 to GeometryDbAliases.h with the 20211015 date.
Contributor
Author
|
@perevbnlgov I'd like to merge this, please review changes. |
plexoos
reviewed
Oct 19, 2021
Comment on lines
+161
to
+162
| {"dev2021", 21201210, 1, "dev2021", "-deprecated- geometry for 2021+ forward program,AgML,xgeometry"}, | ||
| {"dev2022", 21211210, 1, "dev2022", "development geometry for 2022+ forward program,AgML,xgeometry"}, |
Member
There was a problem hiding this comment.
Are the first four digits in the second column supposed to represent the year? Is it intentional to have 2120 and 2121?
Contributor
Author
|
I have advanced the (soon-to-be-deprecated) "development" geometries by
100 years so that the timestamps do not interfere
with the production geometries.
…On 2021-10-19 09:57, Dmitri Smirnov wrote:
@plexoos commented on this pull request.
-------------------------
In StRoot/StChain/GeometryDbAliases.h [1]:
> + {"dev2021", 21201210, 1, "dev2021", "-deprecated-
geometry for 2021+ forward program,AgML,xgeometry"},
+ {"dev2022", 21211210, 1, "dev2022", "development geometry
for 2022+ forward program,AgML,xgeometry"},
Are the first four digits in the second column supposed to represent
the year? Is it intentional to have 2120 and 2121?
--
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub [2], or unsubscribe
[3].
Triage notifications on the go with GitHub Mobile for iOS [4] or
Android [5].
Links:
------
[1] #173 (comment)
[2]
#173 (review)
[3]
https://github.com/notifications/unsubscribe-auth/ANL4LVCEMKAYCAUFPGE3CTLUHV2LNANCNFSM5F5ZA7WA
[4]
https://urldefense.com/v3/__https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675__;!!P4SdNyxKAPE!X1eAAgDX7FCivOdrimixfhoNiwHmLgHhvlO0TMiqwRFtYKp0y7nWhQ5qnEOtgJQ$
[5]
https://urldefense.com/v3/__https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign*3Dnotification-email*26utm_medium*3Demail*26utm_source*3Dgithub__;JSUlJSU!!P4SdNyxKAPE!X1eAAgDX7FCivOdrimixfhoNiwHmLgHhvlO0TMiqwRFtYKp0y7nWhQ5q7W8xfC0$
|
plexoos
approved these changes
Oct 19, 2021
Contributor
|
No objections |
jml985
pushed a commit
that referenced
this pull request
Dec 7, 2021
* Geometry update for 2022 - Implement first cut of the y2022 geometry @ timestamp 20211010.000000 -- sTGC and forward silicon detectors are still in development -- overlaps are a concern for the initial geometries -- expecting geometry updates end of month timescale - Remove deprecated dev2021 geometry model - Advance dev2022 timestamp by 100 years to not interfere * Restore dev2021 @ advanced timestamp / refine comments * And add back in the dev2021 tag to xgeometry * And get the y2022 declaration correct (time stamp, tags...)
marrbnl
pushed a commit
that referenced
this pull request
Dec 8, 2021
* Geometry update for 2022 - Implement first cut of the y2022 geometry @ timestamp 20211010.000000 -- sTGC and forward silicon detectors are still in development -- overlaps are a concern for the initial geometries -- expecting geometry updates end of month timescale - Remove deprecated dev2021 geometry model - Advance dev2022 timestamp by 100 years to not interfere * Restore dev2021 @ advanced timestamp / refine comments * And add back in the dev2021 tag to xgeometry * And get the y2022 declaration correct (time stamp, tags...)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implement first cut of the y2022 geometry @ timestamp 20211010.000000
-- sTGC and forward silicon detectors are still in development / expecting to fold in updates as they become available
-- overlaps are a concern for the initial geometries
Remove deprecated dev2021 geometry model
Advance dev2022 timestamp by 100 years to not interfere