Updates from Tonko on StRoot/RTS/src/DAQ_FCS and TRG_FCS#179
Updates from Tonko on StRoot/RTS/src/DAQ_FCS and TRG_FCS#179akioogawa merged 3 commits intostar-bnl:mainfrom
Conversation
Adding run22 trigger algo in StRoot/RTS/src/TRG_FCS StFcsDb updates on flexible ETGain, fixing reading Gains from text, macro for gain DB StFcsWaveformFitMaker adding stage0 peak finder QA StFcsTriggerSimMaker adding run22 TCU emulator, reading thresholds from text, ET/E gain match selection
akioogawa
requested review from
jdbrice,
jml985,
kehw,
tonko-lj,
veprbl and
zlchang
as code owners
Adding s2_to_dsm return for runStage2()
jml985
left a comment
jml985
left a comment
There was a problem hiding this comment.
The updates to the daq readers are necessary for the offline to match the data taken. The trg_fcs algorithm updates look appropriate, but in any case Akio is the expert who understands the details.
|
Can someone review this please? |
|
As a last resort you may ask @starsdong to approve and merge. |
|
Hi Akio,
Did you use the DSM Algorithm for FCS? If so, could you send me a copy of it? So I can check the logic in StSpinPool/StFcsTriggerSimuMaker. Otherwise as long as the code can compile I have no issue with it.
Zilong
On Nov 9, 2021, at 2:35 PM, akioogawa ***@***.***> wrote:
Can someone review this please?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub<#179 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGH7F3IEVSEGHF7WMUTDW7DULFZZPANCNFSM5GYUWHIQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
I was the peer-reviewer of StFcsWaveformFitMaker at the first place. M StRoot/StFcsWaveformFitMaker/StFcsWaveformFitMaker.cxx (62) |
|
FCS doesn't use DSM. The new DEP boards has FPGA doing trigger algorithms. The VHDL code for new version 202207 included in this PR is being written by Christian right now. The C++ code here is the documentation & specification for him to write VHDL, and will become online bit checker & offline trigger emulator for both data and MC (it has been already used to estimate rate & rescale on MC data). |
|
Hi Hongwei, seems like the system need one more code owner's approval to proceed. Could you please click "approve" so we can merge this into main? |
|
Hi Akio,
Then this code looks good to me!
Zilong
On Nov 10, 2021, at 9:53 AM, akioogawa ***@***.***> wrote:
FCS doesn't use DSM. The new DEP boards has FPGA doing trigger algorithms. The VHDL code for new version 202207 included in this PR is being written by Christian right now. The C++ code here is the documentation & specification for him to write VHDL, and will become online bit checker & offline trigger emulator for both data and MC (it has been already used to estimate rate & rescale on MC data).
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub<#179 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGH7F3J4X42LGAPSJJH4353ULKBNPANCNFSM5GYUWHIQ>.
Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
|
Now I have 4 approvals. But I guess I still need an approval from @jdbrice... |
That's weird or better to say I don't understand it. My guess is that there is a modified file that is missing an approval from a code owner. @veprbl Do you think the approvals need to cover all modified files? |
* Updates from Tonko on StRoot/RTS/src/DAQ_FCS and TRG_FCS Adding run22 trigger algo in StRoot/RTS/src/TRG_FCS StFcsDb updates on flexible ETGain, fixing reading Gains from text, macro for gain DB StFcsWaveformFitMaker adding stage0 peak finder QA StFcsTriggerSimMaker adding run22 TCU emulator, reading thresholds from text, ET/E gain match selection * Adding forgotton Stage2 algo codes * Adding EPD for getName() Adding s2_to_dsm return for runStage2()
* Updates from Tonko on StRoot/RTS/src/DAQ_FCS and TRG_FCS Adding run22 trigger algo in StRoot/RTS/src/TRG_FCS StFcsDb updates on flexible ETGain, fixing reading Gains from text, macro for gain DB StFcsWaveformFitMaker adding stage0 peak finder QA StFcsTriggerSimMaker adding run22 TCU emulator, reading thresholds from text, ET/E gain match selection * Adding forgotton Stage2 algo codes * Adding EPD for getName() Adding s2_to_dsm return for runStage2()
7 participants
Adding run22 trigger algo in StRoot/RTS/src/TRG_FCS
StFcsDb updates on flexible ETGain, fixing reading Gains from text, macro for gain DB
StFcsWaveformFitMaker adding stage0 peak finder QA
StFcsTriggerSimMaker adding run22 TCU emulator, reading thresholds from text, ET/E gain match selection