Skip to content

Add fix for fixed Target run with broken yellowIntensity information#180

Merged
nigmatkulov merged 1 commit intostar-bnl:mainfrom
fisyak:beamInfo
Nov 2, 2021
Merged

Add fix for fixed Target run with broken yellowIntensity information#180
nigmatkulov merged 1 commit intostar-bnl:mainfrom
fisyak:beamInfo

Conversation

@fisyak
Copy link
Copy Markdown
Member

@fisyak fisyak commented Oct 31, 2021

No description provided.

@fisyak fisyak requested review from dmarkh and plexoos as code owners October 31, 2021 15:34
Copy link
Copy Markdown
Contributor

@dmarkh dmarkh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@plexoos
Copy link
Copy Markdown
Member

plexoos commented Nov 1, 2021

Unfortunately, the CI tests wouldn't be able to detect problems from such changes. I hope someone is looking at the nightly test results and will warn us if there are issues.

@starsdong
Copy link
Copy Markdown
Member

Dmitri, shall we merge this request in? I believe the nightly test and later QA will need to check these carefully.

@plexoos
Copy link
Copy Markdown
Member

plexoos commented Nov 1, 2021

Are you fine with the change and approve it, Xin? If so, we can merge unless there are real opposing solutions. (Not sure if #161 can qualify as a solution yet...) I personally don't have an opinion based on the information provided here and will abstain.

Regarding the nightly tests, last time I checked Birdview it was password protected and I could not easily find what I was looking for... but if you can follow up on this that would be great and good enough for me.

@starsdong
Copy link
Copy Markdown
Member

Hi Dmitri,

I think we need both this one (I believe Yuri uses this in the TPC related code) and PR#161 (still needed for others). Gene, is it right?

Thanks

/xin

@genevb
Copy link
Copy Markdown
Contributor

genevb commented Nov 2, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants