StEvent StTriggerData2022 update associate with #203
StEvent StTriggerData2022 update associate with #203klendathu2k merged 2 commits intostar-bnl:mainfrom
Conversation
StEvent StTriggerData2022 update associate with those removal
|
holding the PR.... until trigger group discussion tomorrow |
|
Trigger group may decide leaving trgStructure as is. Still changes in StEvent StTriggerData2022 is needed. |
|
@klendathu2k, I need this quick. Please review. Thanks! |
|
Akio, there should be very little if any need for your critical work to depend on being on the main branch in this repo even less on anyone's approval. From your comment I suspect that your workflow may not be optimal. If you want to discuss this please let me know and I'll make myself available. |
klendathu2k
left a comment
klendathu2k
left a comment
There was a problem hiding this comment.
Looks reasonable. Note that there are function calls and definitions which are commented out, rather than being removed. This could cause confusion when people look at the code later on. In an ideal world, these would be deleted rather than commented out. Alternatively, documentation. Regardless, no need to hold up getting this integrated any further.
|
Pressing the magic green button... |
* Removing some EPD DSM from trigger structure StEvent StTriggerData2022 update associate with those removal * Leaving removed EPD DSMs in place for now, Just adding comments
* Removing some EPD DSM from trigger structure StEvent StTriggerData2022 update associate with those removal * Leaving removed EPD DSMs in place for now, Just adding comments
4 participants
StEvent StTriggerData2022 update associate with removing some EPD DSM from trigger structure for run22