Skip to content

[SL21c] Add Anti-H4 Lambda decay to Anti-He4 + pion- #208

Merged
plexoos merged 3 commits intostar-bnl:SL21cfrom
klendathu2k:SL21c-embedding-patch
Dec 13, 2021
Merged

[SL21c] Add Anti-H4 Lambda decay to Anti-He4 + pion- #208
plexoos merged 3 commits intostar-bnl:SL21cfrom
klendathu2k:SL21c-embedding-patch

Conversation

@klendathu2k
Copy link
Copy Markdown
Contributor

Update to SL21c codes for Run19 AuAu19 embedding. [PR#176 did the same for SL20c.]

  • Add H3LambdaBar decay to gstar library

  • Add H4LambdaBar, He4LambdaBar & He5LambdaBar hypernuclei to StarClassLibrary.
    Add only H4LambdaBar to the particle table (others are placeholders assuming
    a request is made at some point).

(cherry picked from commit c109e4f)

* Add H3LambdaBar decay to gstar library

* Add H4LambdaBar, He4LambdaBar & He5LambdaBar hypernuclei to StarClassLibrary.
Add only H4LambdaBar to the particle table (others are placeholders assuming
a request is made at some point).

(cherry picked from commit c109e4f)
Copy link
Copy Markdown
Contributor

@genevb genevb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is identical to PR #176 , just that the target is SL21c instead of main. Fine with me if there are no other dependencies needed.

@genevb
Copy link
Copy Markdown
Contributor

genevb commented Nov 22, 2021

This is identical to PR #176 , just that the target is SL21c instead of main.

SL21c also needs updated with #184 at some point. Seems like PRs for the same code into a tag is a bit overkill in my opinion, but whatever works...

-Gene

@veprbl veprbl added backport Label for backport changes applied to SLXXy branches and removed backport Label for backport changes applied to SLXXy branches labels Nov 22, 2021
@veprbl veprbl changed the title Add Anti-H4 Lambda decay to Anti-He4 + pion- [SL21c] Add Anti-H4 Lambda decay to Anti-He4 + pion- Nov 22, 2021
Copy link
Copy Markdown
Member

@starsdong starsdong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The He5L and He5Lbar hypernuclei should have the charge of +/- 2, instead of +/- 3.

Correct the He5L(bar) charge to be +/-2.
@klendathu2k
Copy link
Copy Markdown
Contributor Author

The He5L and He5Lbar hypernuclei should have the charge of +/- 2, instead of +/- 3.

Just a note. Change to StarClassLibrary was made, which updates codes used in QA. The definition used in starsim (pams/sim/gstar/gstar_part.g) is correct.

@klendathu2k
Copy link
Copy Markdown
Contributor Author

@ullrich-bnl @fgeurts PR#208 needs your approval before it can be merged.

Copy link
Copy Markdown
Member

@fgeurts fgeurts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok. No comments

This is done by simply checking out the corresponding files:

git checkout aed3dcc -- .github/workflows docker/Dockerfile.root5 tests/ StRoot/macros/rootlogoff.C StRoot/macros/rootlogon.C StRoot/macros/.rootrc

The changes related to ROOT6 CI builds are not included
@plexoos plexoos merged commit ecb764e into star-bnl:SL21c Dec 13, 2021
Copy link
Copy Markdown
Contributor

@ullrich-bnl ullrich-bnl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants