Move back to MagFactor instead of starMagOnl for pre 2012 data (issue #185)

[fisyak]

Fix #185
Move back to use MagFactor instead starMagOnl for data obtained before 2012 (before starMagAvg),
due to missing run numbers used for search in RunLog/onl DB.
Use fixed scale to 4500 kA for starMagOnl.

[genevb]

@dmarkh indicated in the conversation of #185 that he modified starMagOnl to resolve this issue. Should I interpret this code change proposal as an indication that Dmitry's modification did not resolve all issues?

[dmarkh]

Yes, unfortunately, RunLog/onl/starMagOnl table is hardcoded to require runNumber - it is one of those rare exceptions of our "beginTime only" rules. It is nearly impossible to guarantee that all run numbers are properly enabled, therefore roll-back to ScaleFactor (does not use runNumber) is a better option.

…

-Dmitry

On Mon, Nov 29, 2021 at 4:12 PM Gene Van Buren ***@***.***> wrote: @dmarkh <https://github.com/dmarkh> indicated in the conversation of #185 <#185> that he modified starMagOnl to resolve this issue. Should I interpret this code change proposal as an indication that Dmitry's modification did not resolve all issues? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#216 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AHWGXQH7V3Q5X45CUXNZORDUOPUCXANCNFSM5JACGHSQ> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[dmarkh]

LGTM

[genevb]

@plexoos , we'll need an SL21d_1 tag to include this patch if and when this PR is ready for merging. Thanks in advance.