Modifications to StBTofCalibMaker for FXT#241
Merged
plexoos merged 3 commits intostar-bnl:mainfrom Dec 14, 2021
Merged
Conversation
… and modified iterative outlier rejection only in FXT mode. Also added btofFXT to chain options for BFC.
bkimel
requested review from
fgeurts,
genevb,
jdbrice,
klendathu2k,
plexoos and
starsdong
as code owners
starsdong
approved these changes
Dec 13, 2021
Member
starsdong
left a comment
starsdong
left a comment
There was a problem hiding this comment.
The changes look good to me.
Reviewers, would appreciate if you can review/approve the PR at your earliest convenience. We need this to update the SL21d for Run19 FXT data production. Thanks
genevb
approved these changes
Dec 14, 2021
Contributor
genevb
left a comment
genevb
left a comment
There was a problem hiding this comment.
I'm ok with the changes to StRoot/StBFChain/.
fgeurts
approved these changes
Dec 14, 2021
Member
fgeurts
left a comment
fgeurts
left a comment
There was a problem hiding this comment.
Proposed update is ok. The zeroing of NT0 (in the case of only 2 tracks that are too far apart in time) kind of breaks the expected behavior in other modes, but since this is isolated to FXTmode only this is fine
plexoos
added a commit
that referenced
this pull request
Dec 14, 2021
* Changes to StBTofCalibMaker for FXT mode: select vertex within target and modified iterative outlier rejection only in FXT mode. Also added btofFXT to chain options for BFC. * Removed print statements for testing * Do not update generated files manually Co-authored-by: Benjamin Kimelman <bkimel@rcas6016.rcf.bnl.gov> Co-authored-by: Benjamin Kimelman <bkimel@rcas6008.rcf.bnl.gov> Co-authored-by: Dmitri Smirnov <dmixsmi@gmail.com> (cherry picked from commit 4f4cba0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A number of small changes to StBTofCalibMaker for running in FXT mode: select vertex within target, use iterative outlier rejection developed by Bassam, added specific cases to outlier rejection for nT0==1 or 2. These changes were made to both the functions that run over StEvent and MuDst so that there is consistency. Additional changes were made to StBFChain to add "btofFXT" as a chain option (it was not present and there was no way to turn on FXT mode in StBTofCalibMaker) as well as have the "FXT" chain option automatically use this . Checks were performed and confirmed that all changes behaved exactly as expected.