QA run22 + fcs#260
Merged
starsdong merged 2 commits intostar-bnl:mainfrom Dec 23, 2021
genevb:QARun22FCS
Merged
Conversation
Contributor
Author
|
To be clear, I fully expect that CI will fail for this until PR #250 is merged. |
Contributor
Author
|
Now that PR #250 is merged, I ran the CI checks and they passed. I'm hoping we can get this merged today so that FCS can start being included in QA for the ongoing Run 22.... ? Git had not assigned any reviewers for this, so I picked @akioogawa given his FCS involvement, and @starsdong as he pointed out there are needs for Run 22 :-) Thanks, |
akioogawa
approved these changes
Dec 22, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is essentially an update to the Offline QA codes for Run 22 in order to include histograms generated by FCS code. As it depends on that FCS code, this can only be merged after PR #250 is merged.